fix: --spec now allows () in filename #29279
Conversation
|
|
Is there anything I should do since the check for ''Semantic Pull Request'' is failing? |
There was a problem hiding this comment.
I don't know if we want to escape parenthesis in all cases in cypress. the --spec arg can support glob patterns and parenthesis are a valid glob pattern, but I haven't been able to get glob patterns outside of wildcards to work correctly. @jennifer-shehane do you have more knowledge on what's expected? I mainly going off of https://docs.cypress.io/guides/guides/command-line#cypress-run-spec-lt-spec-gt and testing with the CLI and using https://globster.xyz/
AtofStryker
changed the title
Co-authored-by: Bill Glesias <bglesias@gmail.com>
|
@AtofStryker That's a good call out. This bug only happens when you have a closing paren DIRECTLY following an opening paren, so |
|
@jennifer-shehane is the failure in CI legit in relation to the glob changes? |
There was a problem hiding this comment.
@TomasTeixeira2003 There does appear to be a snapshot that has changed with globs - that is failing here. Can you take a look: https://app.circleci.com/pipelines/github/cypress-io/cypress/60955/workflows/e499d77f-ccf3-4aba-8f7f-ed00d2595ba1/jobs/2535654
|
I will look into it today |
|
@tomasbjerre Any chance to look at this? |
@jennifer-shehane you probably tagged the wrong Tomas. But I think it looks great :) |
|
Sorry @TomasTeixeira2003 Any chance to look at this? |
|
I'm sorry, have had a lot of work lately. By tomorrow I will check it. |
|
@TomasTeixeira2003 Just pinging to check in on these updates again. |
|
@TomasTeixeira2003 Any chance you'll be able to fix this PR? We'll need to close otherwise. |
|
I've been working on another feature to rerun failed tests and didn't remember about this. Sorry. By Sunday i will have it working. |
|
What is the yarn command to run only the system-tests? |
|
@TomasTeixeira2003 The instructions are here: https://github.com/cypress-io/cypress/blob/develop/system-tests/README.md |
|
Rerunning the tests here |
|
@TomasTeixeira2003 There are some linting errors |
|
And the other ones are flaky? |
There was a problem hiding this comment.
@TomasTeixeira2003 I'm not seeing this fix working anymore when passing the --spec arg. I understand this may be isolated to running Cypress in the local mode, but I can't see the change fixing the issue now with the recent changes. Including a log of what I was running. The test.cy.js file ran, but the test().cy.js file did not run.
Additional details
Even though there was an existing workaround, it is easier to just allow parenthesis.
PR Tasks
cypress-documentation?type definitions?